Tidy up the shutdown sequence in EnhancedAgent#10
Open
Wanbogang wants to merge 2 commits intoTeneoProtocolAI:mainfrom
Open
Tidy up the shutdown sequence in EnhancedAgent#10Wanbogang wants to merge 2 commits intoTeneoProtocolAI:mainfrom
Wanbogang wants to merge 2 commits intoTeneoProtocolAI:mainfrom
Conversation
Was looking at the agent shutdown logic and noticed the context was being cancelled a bit too early in the process. When the health server stops or cleanup needs to happen, having the main context already cancelled could lead to some flaky behavior. Made a small adjustment to the order: - Health server stops first (it's doing network stuff) - Network disconnects next - Then we cancel the main agent context - Cache cleanup after that - Any final cleanup gets a fresh 5-second context to work with Basically just reordering things so each step has what it needs to finish cleanly. The agent should stop a bit more reliably now. No big changes to functionality, just better flow.
k1ngzonk
approved these changes
Dec 3, 2025
Wanbogang
requested review from
Gradonsky,
bjastrzebski and
pandka22-pz
as code owners
Contributor
|
Hi @Wanbogang , our team has been busy in the Christmas-New Year time. Thank you so much for the improvements, Looks good to me! |
bjastrzebski
approved these changes
Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Was looking at the agent shutdown logic and noticed the context was being cancelled a bit too early in the process. When the health server stops or cleanup needs to happen, having the main context already cancelled could lead to some flaky behavior.
Made a small adjustment to the order:
Basically just reordering things so each step has what it needs to finish cleanly. The agent should stop a bit more reliably now.
No big changes to functionality, just better flow.
Type of Change
Changes Made
Additional Notes
Checklist